Leo's Audio DSP project

Friday, March 09, 2007

Final C code review by Michael Carnes

I adjusted all parameters to create a pleasant sounding chorus with no artifacts. This was a single voice chorus. I created the desired sound. I showed my code to Principal Engineer Michael Carnes to get some feedback. He made the following points:

* The way I am seperating my left and right channels is putting the processor through unnecessary loops which causes inefficiency.

* I am calculating 32-bit sine values for each sample, this is unnecessary and the precise sine values can be replaced by an LUT or by using a triangle modulator which can be generated by doing some simple addition.

None of this came as a surprise since my purpose was to create the effect as quickly as possible. Now I have insights on how to improve efficiency.

We also covered the concept of interpolation to make the chorus sound 'professional grade'. It wouldn't require a lot of time to implement.

At this point, the chorus is sounding good for the purposes of the project. However, I want to branch the code off and try for another week to implement the desired interpolated version.


Post a Comment

<< Home